CommandLineApplication.ExecuteAsync is inherently synchronous

Describe the bug ExecuteAsync is not asynchronous. This seems related to bugs #153 and #196.

All of the ExecuteAsync methods eventually call the method below in CommandLineApplication.Execute.cs.

        public static Task<int> ExecuteAsync<TApp>(CommandLineContext context)
            where TApp : class
            => Task.FromResult(Execute<TApp>(context));

As you may well know, this method uses Task.FromResult to wrap a slew of synchronous calls in a task. This is inherently synchronous and effectively just deceives the consumer into thinking that their commands will execute asynchronously.

Expected behavior Instead of wrapping synchronous code, the asynchronous execution should have its own separate async path.

I’ve logged this as a bug because the methods exist, but I realize that with the amount of work necessary to remediate, this is likely a feature request.

[natemcmaster]

Stale-bot closed this, but I’m reopening because I think this is worth fixing.

[rlvandaveer]

Oddly enough, I just read your Deep-dive into .NET Core primitives a few days ago and it reminded about this issue (author, not subject matter). I’m glad you took it on.