Transpiling to ES5

Hi,

It would be nice if this library would be transpiled to ES5 (in a folder like /dist) using something like babel before getting pushed to git/NPM.
It’s not standard to require the user to transpile stuff installed to node_modules, and without transpiling, it could raise some errors when trying to use this code with specific webpack/grunt/gulp plugins.

My use-case I’m using this together with vue-electron and webpack. When webpack is building the app for production use, it uglifies everything inside node_modules. Sadly, it doesn’t have support for ES6, so your library will raise an error and the build fails. I could add exclude the library, but I guess it would be better to fix it at the root.

[McPo]

try

Option 1:

{
      test: [/node_modules[\\\/](?:electron-settings|key-path-helpers)[\\\/]lib[\\\/](?:.+).js/],
      loaders: ['babel-loader']
},

Option 2:

If that fails to work, change electron-settings in your package.json to

"electron-settings": "McPo/electron-settings#release-dist"

This is my fork which includes electron-settings pre-transpiled and a patch to one of its dependencies. (It also has encryption, although if you don’t set a key, it won’t affect you). Its also a bit older than master (I think its missing the ability to set the Settings filename path, which is what the latest electron-settings allows you to do).

More info on the key-path-helpers issue here https://github.com/atom/key-path-helpers/pull/2#pullrequestreview-7343221

Option 3

Use the latest electron-settings but my patched key-path-helpers. (In package.json)

"electron-settings": "2.2.2",
"key-path-helpers": "McPo/key-path-helpers#splitKeyPath-fix"

[McPo]

In the end I came across a few other projects that hadn’t been transpiled before publishing, and their maintainers were less than helpful (Were adamant they shouldn’t have to transpile before publishing, despite it being recommended by npm)

So I needn’t to come up with a solution to sort all the projects at once.

Within webpack.base.config you’ll notice that Babel is stated to ignore this node_modules folder. What you want is to add another loader which specifies specific projects within node_modules that also need transpiled.

Something like this.

{
                test: [/node_modules[\\\/](?:boom|hawk|hoek|cryptiles|sntp|enfs(?:.+))[\\\/]lib[\\\/](?:.+).js/],
                loaders: ['babel-loader']
            },
            {
                test: /\.jsx?$/,
                loaders: ['babel-loader'],
                exclude: /node_modules/
            },

You’ll notice in the top loader a list of projects separated by |, you’ll need to modify the list to match your own project. Start by removing all other name and adding electron-settings to the list.

On mobile, so if nothing’s clear let me know and I’ll clarify when I’m near my laptop again.