Move tests to GitHub Actions, add Windows Tests
See original GitHub issueFrom #124:
karlhorky: what do you think about adding Windows end-to-end tests to
install-peerdeps
? To catch any errors like this in the future? GitHub Actions and seemingly also Travis CI have the ability to run on Windows…nathanleung: I think that’s a great idea — don’t want to break this package for Windows users in the future if I don’t have to.
ljharb: travis-ci is slow and dying; i’d suggest github actions. I can convert the existing tests to github actions if @nathanhleung is OK with that; windows tests can go in separately/in parallel as a separate workflow.
nathanleung: It would be awesome if you could do that, thanks!
karlhorky: Cool, if this is the way to go, maybe that could be done with a
matrix
- here’s our approach for Preflight: https://github.com/upleveled/preflight/blob/main/.github/workflows/build-lint-test.yml#L7-L10
Issue Analytics
- State:
- Created 3 years ago
- Reactions:1
- Comments:11 (1 by maintainers)
I’ll make a PR soon that converts the tests to GH.
Great, now that https://github.com/nathanhleung/install-peerdeps/pull/139 has been merged, we just have:
eslint-config-react-app
to test situations like https://github.com/facebook/create-react-app/issues/10465