Bad decoding for languages other than English

Hi!

In line 767, var buf = client.inbound.toString('binary', 0, MAX_CONTROL_LINE_SIZE); encoding error will occur when using other languages.

---

I tried change 'binary' to 'utf8' in line 767 and add a function getting binary length from utf8 string:

function byteLength(str) {
  // returns the byte length of an utf8 string
  var s = str.length;
  for (var i=str.length-1; i>=0; i--) {
    var code = str.charCodeAt(i);
    if (code > 0x7f && code <= 0x7ff) s++;
    else if (code > 0x7ff && code <= 0xffff) s+=2;
    if (code >= 0xDC00 && code <= 0xDFFF) i--; //trail surrogate
  }
  return s;
}

Then change line 936 var psize = m[0].length; to var psize = byteLength(m[0]), my problem seems solved.

[aricart]

@Cyperwu Thanks for the report. Could you be so kind as to send us a sample input (subject) and payload that we can take a look at? Thanks!

[aricart]

v2 doesn’t deal with any encoding messages are simply byte arrays.