question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

show brew system tags on user page brew items

See original GitHub issue

From #240

I know there has been talk of tagging/grouping, but in the meantime it would seem that the selected game system for a brew could be represented on the .brewItems. I envision either small color coded labels below the current .info div listing the system and other tags, or using the game system to determine the entirety of each .brewItem card’s background color.

I enisage tags similar to GMB, but for the standard tag groups have an additional tint … e.g. all system tags are green, all type tags are blue, all user-custom tags are white.

  • output an extra line in the .brewItem div.info to show the system tags (if any)
    • <span title="System: 5e">5e</span> or similar
  • provide css styling as desired.

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:6 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
calculuschildcommented, Sep 4, 2022

I’m reviewing @G-Ambatte 's PR #2330, and all the work on sprucing up the User page is looking great. I just had some thoughts and want to see what the consensus is:

As @ericscheid points out, Systems are kind of a subset of Tags, so I ask you all:

  • Do we actually need/want a whole separate property for Systems? It has no real function yet, so now would be the cleanest time to dismantle it before adding it to the user page.
  • If yes, is there any concern for the added space it will take up in the User Page brew items? It’s already getting pretty crowded. Could they just be merged into the “tags” area?
  • If we remove Systems, and just let them fall into standard tags is it worth the potential inaccuracies as far as “Brew search” is concerned? Purely user-created tags would result in duplicate tags (users looking for 5e content would get different results searching “5e” vs “5th edition”), but we would not have to maintain an ever-growing list of systems ourselves or cater to individual requests.
  • If we really wanted to, would it make sense to maintain a predefined list of tags that will be treated as “systems” (for search purposes, etc.) but otherwise are just normal tags? Maybe they display differently or show up as “suggested” when a user starts typing a tag?

@ericscheid @G-Ambatte @jeddai @AlexeySachkov ?

0reactions
ericscheidcommented, Sep 27, 2022

Btw, if we’re looking at merging the brew.systems object into brew.tags, can we take care to be more explicit with the literal values. Having system:3.5e and system:5e without specifying that those are versions of D&D will lead to confusion.

For example: I use HB for my AD&D 2e stuff, but I won’t tag those brews as 2e as that will only annoy Pathfinder 2e users to no end. (And they me in return). Meanwhile there are also 2nd, 3rd, and 4th editions of WFRP. Best to include the base system in the tag value: (e.g.) system:D&D 2e, system:PF 2e, system:WFRP 2e, system:D&D 5e.

Also, we need to add & as a valid character in tags before we go creating system:D&D 5e tags. (see https://github.com/naturalcrit/homebrewery/issues/2333)

Read more comments on GitHub >

github_iconTop Results From Across the Web

brew(1) – The Missing Package Manager for macOS (or Linux)
Show Homebrew and system configuration info useful for debugging. ... --github : Open the GitHub source page for formula and cask in a...
Read more >
List of all packages installed using Homebrew - Ask Different
Running brew list will show a list of all your installed Homebrew packages. In addition, brew list --cask will provide the items installed ......
Read more >
How can i get more info about a brew formula before installing?
You can do a brew home <formula> to fire up a browser from the command line, or brew edit <formula> to examine the...
Read more >
brew/Manpage.md at master · Homebrew/brew - GitHub
Show Homebrew and system configuration info useful for debugging. ... --github : Open the GitHub source page for formula and cask in a...
Read more >
How To Install and Use Homebrew on macOS - DigitalOcean
While the command line interface on macOS has a lot of the functionality you'd find in Linux and other Unix systems, it does...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found