JS Date Object to XML results in empty tag

Hi!

Parsing Date object to XML results in empty tag.

Checklist

• Have you asked your question on Stackoverflow or similar forum?
• Are you running the latest version?
• Have you included sample input, output, error, and expected output?
• Have you checked if you are using correct configuration?
• Did you try online tool?

Input && Code

const j2xParser = require('fast-xml-parser').j2xParser;
let data, parser;

parser = new j2xParser({ format: true });
data = parser.parse({ root: { data: new Date() } });
console.log(data);

Output

<root>
  <data>
  </data>
</root>

expected data

<root>
  <data>Tue Jul 16 2019 11:01:29 GMT+0300 (Москва, стандартное время)</data>
</root>

I’m in RU locale. So it looks like this. What I mean — expected behavior is to see the output of date.toString()

Would you like to work on this issue?

• Yes
• No
• Maybe 😃

As I looked through the sources. A problem is here: https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/src/json2xml.js#L96

typeof Date object is object Can be fixed like this:

- } else if (typeof jObj[key] !== 'object') {
+ } else if (typeof jObj[key] !== 'object' || jObj[key] instanceof Date) {

I don’t know, is it enough or not. It’s working, but maybe there are some things I don’t know about.

Also, it will be great to have an option to control how tag values are processed. There is tagValueProcessor option, but it takes as input string, not an original value, as I see here:

function buildTextValNode(val, key, attrStr, level) {
  return (
    this.indentate(level) +
    '<' +
    key +
    attrStr +
    '>' +
    this.options.tagValueProcessor('' + val) +       //HERE
    '</' +
    key +
    this.tagEndChar
  );
}

[KSDaemon]

Great! Thnx!

[amitguptagwl]

your concern is valid. I’ve fixed the issue. I’ll be publishing them soon.