Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`responseType` – ignore 204 No Content?

See original GitHub issue

My API returns JSON objects always, except in certain situations when a 204 No Content is returned. This is used, for instance, for successful deletes. (for further reading, check out the JSON API spec)

Setting responseType: 'json' blows up when this happens, because an empty response isn’t json. The immediate reaction might be, well, don’t specify the response type. I’d like to, however, because errors and all other unsuccessful deletes are returned in a JSON format.

Do folks think that it makes sense for responseType to skip trying to parse the (nonexistent) body if 204 is returned?

Issue Analytics

State:
Created 7 years ago
Comments:6 (2 by maintainers)

Top GitHub Comments

1reaction

jamespleasecommented, Jul 24, 2016

Sure!

Awesome. I’ll whip up a PR sometime in the next few days.

All I can ask is that you make sure it’s short and not stealing attention from everything else in the README.md - other than that, there’s nothing stopping what you write from getting merged.

Noted. I’ll keep it succinct. ✌️

0reactions

naugturcommented, Jul 24, 2016

Sure!

It’s demonstrated for GET because it wasn’t obvious even for https://github.com/request/request users I’m looking forward to a cleaner explanation. All I can ask is that you make sure it’s short and not stealing attention from everything else in the README.md - other than that, there’s nothing stopping what you write from getting merged.