Device object Allowed Create Without Slug

Environment

• Python version:
• Nautobot version:

Steps to Reproduce

1. Create a job that executes a get_or_create() without a slug

        for device_role in ["Firewall"]:
            DeviceRole.objects.get_or_create(name=device_role)

1. Execute Job
2. Navigate to DCIM>Device Roles

Get reverse match error:

<h1>NoReverseMatch
       at /dcim/device-roles/</h1>
  <pre class="exception_value">Reverse for 'devicerole' with arguments '('',)' not found. 1 pattern(s) tried: ['dcim\\/device\\-roles\\/(?P&lt;slug&gt;[-a-zA-Z0-9_]+)\\/$']</pre>
  
Request Method: | GET
-- | --
http://[::]:8080/dcim/device-roles/
3.1.11
NoReverseMatch
Reverse for 'devicerole' with arguments '('',)' not found. 1 pattern(s) tried: ['dcim\\/device\\-roles\\/(?P&lt;slug&gt;[-a-zA-Z0-9_]+)\\/$']
/usr/local/lib/python3.6/site-packages/django/urls/resolvers.py, line 685, in _reverse_with_prefix
/usr/local/bin/python
3.6.13
['/usr/local/bin',  '/usr/local/lib/python3.6/site-packages/git/ext/gitdb',  '/usr/local/lib/python36.zip',  '/usr/local/lib/python3.6',  '/usr/local/lib/python3.6/lib-dynload',  '/root/.local/lib/python3.6/site-packages',  '/usr/local/lib/python3.6/site-packages',  '/source',  '/usr/local/lib/python3.6/site-packages/gitdb/ext/smmap']
Wed, 26 May 2021 14:54:48 +0000

Expected Behavior

If slug is required then there should be an error on the Job execution

Observed Behavior

Allowed the creation of a Device Role without the slug, causing an error.

[jathanism]

Ideally it would be nice if any create function would handle the slug creation on its own if not supplied, similar to how the UI handles it.

I do agree with this sentiment. Having slugs auto-populate at the model level like they do in the web UI forms would be a nice thing to add for model validation and go some of the way to avoiding this heartache.

[jathanism]

This is working as intended and is not a problem with Nautobot unfortunately.

Because model validation isn’t enforced at the ORM. You have to create an instance, then call full_clean() on the instance before calling save(), or call validated_save() (which is a custom thing we added that does both).

If you’re gonna be blacksmithing objects manually from the ORM, it’s a good idea to get into the habit of doing this!

Further reading: https://docs.djangoproject.com/en/3.2/ref/models/instances/#validating-objects