Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

purpose of preventClickOnDrag ?

See original GitHub issue

Description

Can someone explain a bit more what preventClickOnDrag does? A click event for me is indeed bubbling up the DOM whenever I drag the carousel – with preventClickOnDrag set to true, is the click event not suppose to bubble up?

These are my dependencies:

 "@egjs/flicking": "^4.1.0",
 "@egjs/vue-flicking": "^4.1.0"

I’m currently using Vue 2.6.11 and typescript 3.7.4

Issue Analytics

State:
Created 2 years ago
Comments:7 (4 by maintainers)

Top GitHub Comments

2reactions

WoodNeckcommented, Jul 1, 2021

Thanks for the explanation, that’s a very good point for improvement. I’ve just tested the current preventClickOnDrag and looks like it doesn’t work correctly due to the drag checking logic. I think I can fix this by updating drag-checking logic & capturing click events in the viewport element. I’ll leave a comment here after releasing the fix.

1reaction

birnbecommented, Jul 8, 2021

Hi. @birnbe Currently, PR( #478 ) has been completed, and reviews remain. Member in charge is on vacation, so it will probably be merged around next Monday. 😃

On July 12th? Great, much appreciated!

Top Results From Across the Web

fix preventClickOnDrag option working for less than 1px by ...

Details According to document, preventClickOnDrag option prevent click event if the user has dragged at least a single pixel on the viewport element....

Options | Flicking - NAVER Open Source

preventClickOnDrag . Automatically prevent click event if the user has dragged at least a single pixel on the viewport element.

Introducing Flicking v4 with more customization and UI ...

On the other hand, Flicking uses the user's UI as the top priority. ... options/events such as “preventClickOnDrag” or “reachEdge”.

social-management / react-calendar-timeline / fb432ee232d ...

use clickTolerance instead of hardcoded value in PreventClickOnDrag. Find text in diff and context lines. Hide/show file tree. __tests__/components.

@egjs/react-flicking: Versions | Openbase

getRenderingPanels uses old list (#538); Flicking is animating on moveEnd ... preventClickOnDrag is not working on non-native clickable elements (#470) ...