question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

I use Serilog.Timings to log the outbound HTTP calls and those can be completed, abandoned and failed (at least, for us): the difference between “completed” and “failed” is the one between successful and unsuccessful HTTP status code.

So what I would like to have is the ability to

  1. have different outcomes in the log (“completed” and “failed”)
  2. differentiate them by the log level

All of this can be (quite easily, but a bit messily) achieved by adding an overload to Complete accepting log level and outcome, or if we want more “graceful” solution - by adding another method very similar to Complete.

I can do a PR for whichever solution you prefer.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:11 (11 by maintainers)

github_iconTop GitHub Comments

1reaction
srogovtsevcommented, Feb 9, 2019

I will try picking up AddProperty either today or tomorrow, I like the idea. The only thing that is missing is logging the exception, but that can be remedied by adding similar SetException.

0reactions
nblumhardtcommented, Feb 15, 2019

Odd - looks like pre-release package publishing is broken. I’ll have a look shortly - the dev branch builds should be published to NuGet.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Fail - AWS Step Functions
The Fail state only allows the use of Type and Comment fields from the set of common state fields. In addition, the Fail...
Read more >
Propogating error message through Fail state in aws Step ...
I am using Fail states to handle errors within the workflow. I would like to propagate some of the json from the Step...
Read more >
Failed state
A failed state is a state that has lost its effective ability to govern its populace. A failed state maintains legal sovereignty but...
Read more >
Add step input and step output to Fail State · Issue #16029 ...
Proposed Solution​​ Let fail state use parameters, or even better all the input/output manipulation methods that are present in a Pass state.
Read more >
Troubleshoot Azure Microsoft.Network failed Provisioning ...
Being in the failed state doesn't necessarily mean that the resource isn't functional. In most cases, it can continue operating and serving ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found