Running nbqa with flake8 complains about blank lines on notebook cells with functions

Consider a cell containing a function

# cell contents
def get_dataset():
    return make_classification(
        n_samples=1000, n_features=20, n_informative=15, n_redundant=5, random_state=7
    )

I am getting the warnings

• E302 expected 2 blank lines, found 1.
• E305 expected 2 blank lines after class or function definition, found 1

[MarcoGorelli]

I’m not sure how we could consistently put the correct number of blank lines between cells…I’m tempted to just have a “suggested configs” document in which we suggest which errors to ignore for which tools. Or do you think this is solvable?

[girip11]

After the split, we can strip \n from the cell content

yes but if isort makes any changes, then won’t it (potentially) return the wrong exit code? e.g. like this it could happen that you run nbqa isort notebook.ipynb and you get

fixing notebook.ipynb

but then if you do git diff you see that nothing has changed

Great point. I didn’t think isort would change the file when no imports has to be sorted.