[jest-plugin-set] Set variables should be created before beforeEach is called

Description

Nested set calls must ALL come before beforeEach in order to be set properly. Otherwise, it’ll use the values from outer set calls which is incorrect

Screenshot

Test Plan

[negativetwelve]

Hi @bxt, thanks for your comment. If I remember correctly, the issue comes from something like:

import set from 'jest-plugin-set';

describe('outer', () => {
  set('a', () => 1);
  set('b', () => a);

  beforeEach(() => {
    console.log(a, b);
  });

  describe('inner', () => {
    set('a', () => 5);

    beforeEach(() => {
      console.log(a, b);
    });

    it('returns the correct value', () => {
      expect(a + b).toEqual(10);
    });
  });
});

It will log:

1, 1
1, 1

when it should be:

1, 1
5, 5

and if I remember correctly, the test should fail on this and return 2 instead of 10. Let me know if you’re seeing the same behavior.

(I wrote the code without testing, please excuse if there are small errors)

[timscott]

I ran into this also today. Here’s another repro.

describe('', () => {
  set('a', () => x)
  beforeEach(() => {
    console.log(a);
  })
  describe('', () => {
    set('x', () => 1)
    test('', () => {
      expect(a).toEqual(1)
    })
  })
})

Fails with ReferenceError: x is not defined on the second line.

Pulling variables from inner contexts to use in beforeEach is definitely a useful pattern which can eliminate a lot of duplicate code. Something I always do in rspec.