Menu opens whenever I click any link anywhere

There was an issue #91, which unfortunately was promptly closed by the author without providing much explanation. Now I’m hitting the same issue and I have no idea what’s wrong.

const burgerMenu = <Menu
          isOpen={isSidebarOpen}
          customBurgerIcon={false}
          customCrossIcon={false}
        >

I open the menu by invoking this:

      openMenu = () => {
        this.setState({
          isSidebarOpen: true,
        });
      }

and rely on clicking on overlay for closing it.

The problem is every time I click on a link anywhere it triggers opening the menu. Has anyone seen this behaviour?

[denisftw]

@t-sean Indeed! Thanks a lot for your suggestion; this solves my issue. Basically, I needed onStateChange to update my internal state after clicking on the overlay. If I don’t do that then the state remains open. In this case, clicking the Link triggers componentWillReceiveProps on the Menu, and since isOpen is wrong at this point, the Menu shows up.

[t-sean]

I saw something similar while handling my own isOpen state. Clicking out of overlay, or pressing escape would change the internal state of burger-menu, but obviously not update my own isOpen state. So if i closed the menu one of those ways, my state was still set to open, and a re-render from prop changes would cause the state check to open the menu.

This would also cause what seemed like having to double click my open/close icon, the first click updating my open state to false, then the setting it to open.

Adding the onStateChange handler to my app kept them both in synch.