When a relationship has been mapped already (scalar), it is re-mapped to an iterable if the object model is not navigable in both directions

The following entities:

@NodeEntity
class MyEntity{
    @GraphId Long graphId;
}

class MyResource extends MyEntity{
    @Relationship(type="HAS_CHILD", direction = Relationship.INCOMING)
    MyContainer parent;
}

class MyContainer extends MyResource{
    @Relationship(type="HAS_CHILD", direction = Relationship.OUTGOING)
    List<MyResource> children = new ArrayList<>();

    MyResource additionalChild;
}

created this graph

MyContainer{
  additionalChild=MyResource{graphId=null, name='anotherChild'} 
  children=[
    MyResource{graphId=null, name='child1'}, 
    MyResource{graphId=null, name='child2'}
  ]
}

loading it back gives:

MyContainer{
  additionalChild=MyResource{graphId=95, name='anotherChild'} 
  children=[
    MyResource{graphId=95, name='anotherChild'}, 
    MyResource{graphId=97, name='child2'}, 
    MyResource{graphId=96, name='child1'}
  ]
}

Somehow additionalChild bleeds over into the children collection.

Full example is on Github: https://github.com/m2spring/ogm-eval/tree/single-child-in-children

[luanne]

@charliebonza there are two reasons your test was failing. The first is that the annotations need to be explicit. INCOMING relationships must have annotations on methods as well if present.

In cases where the mapping may be ambiguous like the one in this issue as well as your test case, recommendation is that a) the objects be navigable in both directions and b) the @Relationship annotations are explicit. This means if you have methods, they must be annotated.

The User should now look like:

    @Relationship(type = "OWNER", direction = Relationship.INCOMING)
    private Set<OwnedLicensedEntity> owned;

    @Relationship(type = "LICENSEE", direction = Relationship.INCOMING)
    private Set<OwnedLicensedEntity> licensed;

    public Long getId() {
        return id;
    }

    public void setId(Long id) {
        this.id = id;
    }

    public String getName() {
        return name;
    }

    public void setName(String name) {
        this.name = name;
    }

    @Relationship(type = "LICENSEE", direction = Relationship.INCOMING)
    public Set<OwnedLicensedEntity> getLicensed() {
        return licensed;
    }

    @Relationship(type = "LICENSEE", direction = Relationship.INCOMING)
    public void setLicensed(Set<OwnedLicensedEntity> licensed) {
        this.licensed = licensed;
    }

    @Relationship(type = "OWNER", direction = Relationship.INCOMING)
    public Set<OwnedLicensedEntity> getOwned() {
        return owned;
    }

    @Relationship(type = "OWNER", direction = Relationship.INCOMING)
    public void setOwned(Set<OwnedLicensedEntity> owned) {
        this.owned = owned;
    }

and OwnedLicensedEntity like

@Relationship(type = "OWNER", direction = Relationship.OUTGOING)
    private User owner;

    @Relationship(type = "LICENSEE", direction = Relationship.OUTGOING)
    private Set<User> licensees;

    @Relationship(type = "LICENSEE", direction = Relationship.OUTGOING)
    public Set<User> getLicensees() {
        return licensees;
    }

    @Relationship(type = "LICENSEE", direction = Relationship.OUTGOING)
    public void setLicensees(Set<User> licensees) {
        this.licensees = licensees;
    }

    @Relationship(type = "OWNER", direction = Relationship.OUTGOING)
    public User getOwner() {
        return owner;
    }

    @Relationship(type = "OWNER", direction = Relationship.OUTGOING)
    public void setOwner(User owner) {
        this.owner = owner;
    }

The second issue contributing to this behaviour was issue #85 which is now fixed and available in 1.1.4-SNAPSHOT

[tarehart]

@luanne perfect, thank you!