TimeoutError: Navigation Timeout Exceeded: 30000ms exceeded

I found out that busy build machines running conversion experience puppeteer error: TimeoutError: Navigation Timeout Exceeded: 30000ms exceeded

It originates from this line: await this[_page].goto(fileUrl(tempFile.path));

As this is this uses browser just for rendering, not networking, it seems appropriate fix would be to configure page timeouts (as only page objects allow that):

    if (!this[_browser]) {
      this[_browser] = await puppeteer.launch(this[_options].puppeteer);
      this[_page] = await this[_browser].newPage();
    }

->

    if (!this[_browser]) {
      this[_browser] = await puppeteer.launch(this[_options].puppeteer);
      this[_page] = await this[_browser].newPage();
      this[_page].setDefaultTimeout(0); // Disabled timeout
    }

[neocotic]

Ah sorry, I didn’t see the distinction between browser instance startup timeout and page navigation timeout. You’re right that this isn’t currently supported via puppeteer options, however, I’m still a bit curious as to why it should ever timeout after 30 seconds. Are the SVGs you’re rendering containing remotely hosted resources (e.g. images, fonts)?

If we were to disable the page navigation timeout, I think it would need to be done on a opt-in basis as I feel like this is implementation detail for puppeteer itself which I’d like to keep out as much as possible.

What I might consider is splitting the existing puppeteer options to be passed down as follows:

• puppeteerLaunch - options passed to puppeteer.launch (i.e. https://github.com/puppeteer/puppeteer/blob/v1.10.0/docs/api.md#puppeteerlaunchoptions)
• puppeteerPageGoto - options passed to page.goto (i.e. https://github.com/puppeteer/puppeteer/blob/v1.10.0/docs/api.md#pagegotourl-options)
• puppeteer - an alias for puppeteerLaunch for backwards compatibility

This should be able to offer greater control for those like yourself that need it and then you could simply do the following:

const { createConverter } = require('convert-svg-to-png');
await this.converter.convertFile(sourcePath, { puppeteerPageGoto: { timeout: 0 }});

[lietusme]

For now I worked around this by catching exception and retrying few times before failing.