Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Refactor RPC methods

See original GitHub issue

Problem:

There are several RPC call methods that use addresses as parameters. Currently neow3j handles these as String and does not check whether it is a valid address before sending an RPC request. This results in the node returning the error message Invalid params, which is not be very specific, especially in method calls with many parameters.

Solution Suggestion:

A separate class Address for Neo addresses could enforce correct addresses before any request is sent.

Issue Analytics

State:
Created 2 years ago
Comments:10 (10 by maintainers)

Top GitHub Comments

1reaction

gsmachadocommented, Apr 6, 2021

@csmuller yes, agree.

Could we try to squeeze this issue to this milestone as well, @mialbu? if yes, please set the milestone appropriately and put to ToDo. 😄

1reaction

csmullercommented, Apr 6, 2021

It doesn’t have a high priority in my opinion but it fits well with other maintenance tasks in this milestone, like #480 or #473.

Top Results From Across the Web

RPC 2.0 Refactor - Protocol Design - Nano Forum

RPC 2.0 Refactor · Remove unused RPCs, make changes that require breaking the existing functionality, and add new RPC functionality · Improve ...

Refactor the RPC tests and pull out helper methods into a testing ...

To avoid future code duplication and the problems associated with it, we should clean up the duplicate code in our tests and pull...

D7990 refactor: Pass NodeContext to RPC and REST methods ...

This looks like it'd be better treated as a private member and passed in during init. This revision now requires changes to proceed....

Revert "Refactor RPC client" · 56537c4c69 - oslo.messaging ...

This refactor breaks the RPClient API Closes-bug: #1584889 Conflicts: ... oslo_messaging/rpc/client.py ... def _make_message(self, ctxt, method, args):.

token-server: Finish refactoring RPC server implementation. (issue ...

RPC methods are implemented and tested separately, not in a single giant *.go file. Description: token-server: Finish refactoring RPC server implementation.