Questions

How can we disable Hangfire? - We’ve use hangfire in the past and it hasn’t worked well for us, I would like to disable it, usually there is a setting in the appsettings. Ideally should be its own project not tied to the UI so you can scale up/out with it.

Auth options (google/ms) - Is there no config options to disable these? Dont I need to set a ClientId/Secret for microsoft/AAD? Where? Again should be tied to appsettings options if not enabled dont show the options.

Tenants - Not sure what this is doing, can you login to a different tenant? Database per tenant? When you login what tenant are you in, what tenant are the “products” associated with, pick lists are system level or tenant? There seems to be a disconnect between the demo/tenants or its not implemented.

Logs - This appears empty, I do see a log file though

Quick look thru the code there seems to be a bunch of random //ToDo: impementing xxxx (These seem implemented, so why are they todos?)

In ProductsPaginationQuery.cs there is a comment of //the currently logged in user on a .ToString that shows the filters applied. The same file has unused localizer.

Date filters - you seem to be converting to string and the back to datetime for some reason.

DateTime today = DateTime.Now.Date;
DateTime start = today;  // this is already 00:00:00 for the date
DateTime end = today.AddDays(1).AddTicks(-1);  // 23:59:59.9999999 for the date
DateTime last30day = today.AddDays(-30);  // this is already 00:00:00 for the date 30 days ago

Not sure if VS has the same inspections as Rider but rider is showing a bunch of warning that could easily be cleaned up. Rider also offers free licenses for open source projects.

[neozhu]

Thanks for the suggestions, @bakes82 . I agree with your ideas about the todos and installation files. A blank install with basic features and using appsettings to toggle options are great ideas. Regarding multi-database support, it’s on my list to consider. Would you be interested in contributing a PR for these improvements? I’d love more community involvement.

[neozhu]

Thanks for sharing the console app generator. However, I believe it’s not suitable for other projects due to many dependencies. It might not be necessary to use this template for new projects, especially with the current lack of documentation and other issues.