Fastify registration omits apolloServer.start(), which throws an error at apolloServer.createHandler()

I’m submitting a…

[X] Regression 
[X] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

When attempting to start an application that uses @nestjs/platform-fastify@7.6.17 and @nestjs/graphql@7.10.6, the Apollo Server throws the following error that prevents the application from starting:

[Path]/node_modules/apollo-server-core/src/ApolloServer.ts:486
      throw new Error(
            ^
Error: You must `await server.start()` before calling `server.createHandler()`
    at ApolloServer.assertStarted ([Path]/node_modules/apollo-server-core/src/ApolloServer.ts:486:13)
    at ApolloServer.createHandler ([Path]/node_modules/apollo-server-fastify/src/ApolloServer.ts:45:10)
    at GraphQLModule.<anonymous> ([Path]/node_modules/@nestjs/graphql/dist/graphql.module.js:150:45)
    at Generator.next (<anonymous>)
    at [Path]/node_modules/tslib/tslib.js:117:75
    at new Promise (<anonymous>)
    at Object.__awaiter ([Path]/node_modules/tslib/tslib.js:113:16)
    at GraphQLModule.registerFastify ([Path]/node_modules/@nestjs/graphql/dist/graphql.module.js:143:24)
    at GraphQLModule.<anonymous> ([Path]/node_modules/@nestjs/graphql/dist/graphql.module.js:118:28)
    at Generator.next (<anonymous>)

Expected behavior

The application should start without an error and was previously working.

Minimal reproduction of the problem with instructions

Adding await apolloServer.start() to line 228 of lib/graphql.module.ts seems like it will fix the issue, but I’m not sure if that’s the appropriate place to put it from an architecture perspective. I did this via yarn patch and the application starts successfully. My repo and patch are available on the dev-nx branch at troncali/nest-vue.

• git clone --depth=1 -b dev-nx https://github.com/troncali/nest-vue
• cd nest-vue
• yarn install
• Patch is located at ./.yarn/patches/@nestjs/graphql.patch
• Working on a template repository, so some minimal setup is needed – cp .env-template .env – echo "username" > ./src/docker/secrets/DB_USERNAME – echo "password" > ./src/docker/secrets/DB_PASSWORD
• yarn nx serve - to test that it’s working with the patch; no error in console
• http://localhost:3001/v1 shows “Hello World!”
• Stop the application
• yarn add @nestjs/graphql to revert to the unpatched version
• yarn nx serve - to show the unpatched error

Environment

Nest version: 7.6.17
 
For Tooling issues:
- Node version: 16.1.0  
- Platform: Mac 

Others:
- Package Manager: Yarn 2, with PnP enabled
- Build Tools: @nrwl/nx

[kamilmysliwiec]

This should be fixed in v7.11.0

[p-j]

It happened to me as well due to apollo-server-fastify@^3.0.0-preview.0 a temporary fix was for us to add those lignes to package.json

"resolutions": {
    "apollo-server-env": "^2 || 3.0.0-alpha.3",
    "apollo-server-fastify": "^2 || 3.0.0-alpha.3",
    "apollo-server-core": "^2 || 3.0.0-alpha.3"
  },

forcing the resolution of apollo-server packages to the working aplha.3 version instead of the recently published preview.0 one.