[Regression] type-graphql datetime cannot be parsed

I’m submitting a…

[x] Regression 
[ ] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

I upgraded @nestjs/graphql from 6.0.5 to 6.2.1 today and found this regression.

When I did the mutation postPoem like

mutation {
  postPoem(newPoem: {
    "title": "AA",
    "content": "BB",
    "isPublic": true
  }) {
    id
    createdAt
  }
}

The error GraphQL Cannot return null for non-nullable field 'createdAt' occurred. When I did not request the createdAt property, it worked well.

Below is the complete generated schema

# -----------------------------------------------
# !!! THIS FILE WAS GENERATED BY TYPE-GRAPHQL !!!
# !!!   DO NOT MODIFY THIS FILE BY YOURSELF   !!!
# -----------------------------------------------

input CreatePoemInput {
  title: String!
  content: String!
  isPublic: Boolean = false
}

input CreateUserInput {
  name: String!
  email: String!
  password: String!
}

"""
The javascript `Date` as string. Type represents date and time as the ISO Date string.
"""
scalar DateTime

type JsonWebToken {
  token: String!
  expiresAt: Float!
}

type Mutation {
  signUp(newUser: CreateUserInput!): Session!
  logIn(password: String!, email: String!): Session!
  postPoem(newPoem: CreatePoemInput!): Poem!
  deletePoem(id: String!): String!
  updatePoem(newPoem: CreatePoemInput!, id: String!): Poem!
}

type Poem {
  id: ID!
  title: String!
  content: String!
  isPublic: Boolean
  createdAt: DateTime!
  updatedAt: DateTime!
  author: User!
}

type Query {
  user(id: String!): User!
  poem(id: String!): Poem!
  allPublicPoems(take: Float, skip: Float): [Poem!]!
  myPoems(take: Float, skip: Float): [Poem!]!
}

type Session {
  jwt: JsonWebToken!
  user: User!
}

type User {
  id: ID!
  name: String!
  email: String!
  poems: [Poem!]!
}

Expected behavior

createdAt should be parsed correctly.

Minimal reproduction of the problem with instructions

My Repo A PostgreSQL should be set up in src/database/database.provider.ts before running the program.

What is the motivation / use case for changing the behavior?

Environment

Nest version: 6.2.4

 
For Tooling issues:
- Node version: 10.15.3  
- Platform: Mac 

Others:

I am sure this is directly related to @nestjs/graphql. Actually I upgraded all nest.js libraries. The error occurred. I then downgraded only @nestjs/graphql, and the error disappeared.

[lucifer1004]

I have solved this issue in this commit

Apparently, I should have used new Date() directly instead of new Date().toISOString(), but it worked well in @nestjs/graphql <= 6.0.5.

So this issue can be closed now.

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.