Usage of @ResolvePoperty() causes multiple instantiations of resolver

I’m submitting a…

[ ] Regression 
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

When a @ResolveProperty() function gets executed and a request scoped service was injected into the resolver a new instance of a resolver gets created each time a @ResolveProperty() function gets executed.

Expected behavior

Only one instance of the resolver and the service get created per request.

Minimal reproduction of the problem with instructions

https://github.com/xXKeyleXx/graphql-minimal-resolve-property

Execute the following query and watch the console output.

query {
  getTestsByIds(ids: ["1","2","3","4"]) {
    id
    parent {
      id
    }
  }
}

Comment out the property resolver and it works like expected.

What is the motivation / use case for changing the behavior?

If a new instance of a dataloader gets created each time a property gets resolved it defeates the purpose of the dataloader 😅

Environment

@nestjs/common: 6.2.4,
@nestjs/core: 6.2.4,
@nestjs/graphql: 6.2.1,
apollo-server-express: 2.5.0
type-graphql: 0.17.4
graphql: 14.3.0 
 
For Tooling issues:
- Node version: v10.15.3
- Platform:  Linux (Docker) / Windows

[kamilmysliwiec]

Fix published as 6.2.3

[kamilmysliwiec]

It sounds more like a circular dependency issue in your code.