Proposal: make use of injection-js

I’m submitting a…

[ ] Regression 
[ ] Bug report
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

• At this time we cannot use InjectionToken, an Angular-like feature, and have to manually type string to @Inject (I could not use const variable too, see my comment )

UPDATE: I have figured out this is an limitation of Nest when you could not declare token in the same file with Module. That’s why I propose that we should use injection-js instead current DI system.

• Lack of type checking for components array declaration in Module. In Angular when we try to declare providers in @NgModule, we have nice type checking and auto completion. But we we don’t have that nice feature in Nestjs @Module components declaration.

Expected behavior

We should make use of injectable-js, a light weight and well tested DI framework extracted from Angular core v4.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

With that we can support InjectionToken for creating unique token across application as well as reuse code across server and client side. (Token in Angular use InjectionToken)

Environment

Nest version: 4.6.0

 
For Tooling issues:
- Node version: 8.9.4  
- Platform:  Mac

Others:

[shekohex]

Hi @sandangel That sounds strange to me, Nest Is using Reflection under the hood , maybe imo it is a limitation of the library reflect-metadata or Typescript idk, but Angular or injection-js using another approach but it is the same concept. due to some limitation on the browser, and you know Angular SHOULD have support for massive number of browsers. actually, about month ago, I was playing with Injection-js and decided to create a simple core framework for learning purpose, something like Nest, but instead of creating my own Depancy Injection Engine, I prefered to go with Angular’s, here is a minimal repo: Core 101. I learned a lot of techniques and how Angular or Nest works. anyway, I think there is no reason to change the Nest DI Engine with Angular’s one. Hope this will help you.

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.