(question) How to inherit exposed controller http methods?

Hi, It’s possible to inherit parent controller methods? I tried to create kind of RestController with CRUD methods, but the child seems to not get any of them.

Any idea?

[kamilmysliwiec]

This feature is available since v4.6.0 🎉

[jgj]

I have this exact use case and was surprised to find it didn’t work. A more concrete example (Using TypeORM):

export abstract class EntityController<T> {
    constructor(protected readonly service: EntityService<T>) { }

    @Get()
    async findAll() {
        return this.service.findAll();
    }

    @Get(':id')
    async getById(@Param() params) {
        return this.service.getById(params.id);
    }

    @Post()
    async create(@Body() data: Partial<T>) {
        return this.service.create(data);
    }
}

Every single one of my TypeORM entities should expose basically the same restful CRUD interface and, using generics, be type safe about the underlying Entity model. I’ve already done this with the service that wraps the typeorm repository (EntityService<T>). An extending controller looks like:

// ThingService extends EntityService<Thing>

@ApiUseTags('things')
@Controller('things')
export class ThingController extends EntityController<Thing> {
    constructor(private readonly thingService: ThingService) { super(thingService) }
}

This seems like a perfectly valid pattern to me, and one which will save me tons of boilerplate/copy and pasting. None of the essential CRUD logic differs between any of my entities. And, if it did, the most appropriate place to handle it would be the Service or Middleware/Interceptors/Pipes/Guards, not the controller. The value of REST is that the interface is based on the shape of the state being transferred and a set of known verbs. The verbs don’t change between controllers and the shape of the state is determined by the generic type argument.

If there is a limitation or difficulty in supporting this pattern I understand not being willing to support it. But to say there isn’t a valid use case is unfair.