External Dtos (i.e. in node_modules) do not keep Api Property options

I’m submitting a…

[ ] Regression 
[ X ] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

This behaviour: https://github.com/nestjs/swagger/issues/529

Dtos from within the src folder are rendered with optional properties as optional. Dtos from outside the src folder (that have been created and compiled with nest) are rendered as required:

Expected behavior

Since the js of the compiled EXTERNAL dtos have references to IsOptional, and also have the language specifc ‘?’ syntax before them, they should be shown as optional.

Minimal reproduction of the problem with instructions

Attached is a repo: https://github.com/cjancsar/regression-external-dto-nestjs Note: it pulls the external DTO from the published package here:

• https://github.com/cjancsar/regression-common
• https://www.npmjs.com/package/regression-external-dto

What is the motivation / use case for changing the behavior?

This is a bug.

Environment

Nest version: 6.11.8 (common)

 
Others:

[kamilmysliwiec]

I’ve already replied to this issue and you ignored my response.

This is not a bug - Plugin won’t run for node_modules. If you have external packages which export DTOs, all its files should be already compiled with Nest CLI, and hence, have the metadata in the generated JS files. Thus, @nestjs/swagger will use this pregenerated metadata. Just ensure to compile packages with Nest CLI (and plugin enabled) instead of tsc. TypeScript compiler won’t generate & modify AST for your JS files from node_modules, this would be ridiculous.

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.