Throwing HealthCheckError in synchronous HealthIndicatorFunction does not work properly

Is there an existing issue for this?

• I have searched the existing issues

Current behavior

There is an issue with non-async health indicator functions due to the following:

https://github.com/nestjs/terminus/blob/ea06b34b60d7710fd1e0227532960a678deaa355/lib/health-check/health-check-executor.service.ts#L63

If an error is thrown synchronously, then the health check will reply with {"statusCode":500,"message":"Internal server error"} and the server will log the error.

Minimum reproduction code

@Get()
  @HealthCheck()
  async check() {
    const result = await this.health.check([
      () => throw new HealthCheckError('error', {}), // if changed to `async () => `, it works
    ])
  }

Steps to reproduce

No response

Expected behavior

It should not depend on the function being async.

Package version

9.1.3

NestJS version

not relevant

Node.js version

not relevant

In which operating systems have you tested?

• macOS
• Windows
• Linux

Other

No response

[BrunnerLivio]

Released with 9.1.4 🎉

[BrunnerLivio]

@andreialecu Alright makes sense to me! Let’s go forward with your PR then 😃