Request must be send two times to make request filters applied

According to my controller:

@Crud({
  model: {
    type: Lead,
  },
  query: {
    alwaysPaginate: true,
    join: {
      produit: {
        allow: ['nom'],
        eager: true
      }
    }
  },
  params: {
    id: {
      field: 'id',
      type: 'uuid',
      primary: true
    }
  }
})
@UseGuards(AuthGuard('jwt'))
@UseInterceptors(ClassSerializerInterceptor)
@Controller('leads')
@ApiUseTags('Leads')
@ApiBearerAuth()
export class LeadController implements CrudController<Lead> {
  constructor(public service: LeadService, public jwtUserService: JwtUserService) { }

  get base(): CrudController<Lead> {
    return this;
  }

  @Override()
  async getMany(
    @ParsedRequest() req: CrudRequest,
    @Headers() headers,
    @Query() query
  ) {
    const user = await this.jwtUserService.getUserFromJwt(headers.authorization);
    const hasQuery = (key: string) => !!query && !!query[key];

    if (user.role === 'user') {
      req.options.query.filter = {
        user: {
          $eq: user.id,
        }
      };
    }

    req.options.query.filter = {
      ...req.options.query.filter,
      ...hasQuery('produit') && { 'produit.id': { $in: query.produit } },
      ...hasQuery('statut') && { statut: { $in: query.statut } },
    };

    return this.base.getManyBase(req);
  }
}

Let’s take the following routes (GET): If I’m calling

http://localhost:3000/leads

It returns the normal collection of Lead resources:

{
  "data": [
    // Some data
  ],
  "count": 100,
  "total": 100,
  "page": 1,
  "pageCount": 1
}

But if I’m calling a first time:

http://localhost:3000/leads?statut%5B%5D=en_cours

It returns the same content as the global route /leads

But if I’m calling it a second time, it returns the expected result:

{
  "data": [],
  "count": 0,
  "total": 0,
  "page": null
}

I really don’t understand why should I send the same request two times to get the right result. Moreover, req.options.query.filter has always the right value each time I make a request. It’s only the result that is incoherent. (Sorry if it’s not related to the library, but I really don’t get it).

[michaelyali]

Here are the scenario and explanations of your bug which is not a bug actually but a misunderstanding of crud lib internals which is totally fine. I’ll explain more detailed:

1. Each request is handled by the CrudRequestInterceptor which then stores and passes a parsed request params/query in the req.parsed which is being used by CrudController methods.
2. You modify req.options.query.filter in the controller’s method but the method will not handle it and will not take this filter into account because of all the logic related to the merging options.filter with the request query/params is already being done by the CrudRequestInterceptor. That’s why a method cares only about req.parsed.search. And that’s why during the 1st method call you’re getting one result.
3. When you do this req.options.query.filter = ... you thus modify CrudOption object by a link. And during the 2nd method call your CrudOptions object is already modified with your changes and that’s why the CrudRequestInterceptor parses a request with your query and creates a correct req.parsed.search object. That’s why your 2nd method call will give you another result.

Hope this explanation helped

[maximelafarie]

Ok thank you for these explanations. 🖖