question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Make Conductor model extendable

See original GitHub issue

Hello, I was thinking to “change” (more precisely extend) my data model of conductor. Today I could fork the project and edit directly. But I was thinking to a more generic approach, using in the interface only generics that extend your base model. For example:

public interface ExecutionDAO<T extends Task, W extends Workflow> {
    List<T> getPendingTasksByWorkflow(String taskName, String workflowId);
    W getWorkflow(String workflowId, boolean includeTasks);

What do you think? Is there a better approach to avoid this huge refactoring?

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:11 (10 by maintainers)

github_iconTop GitHub Comments

2reactions
apanicker-nflxcommented, Oct 22, 2019

@andrea11 and @AlexVinogradov Thank you for your suggestions and contributions. This is breaking change on the interface contracts and anyone extending the current interfaces would need to update their codebases. While this is useful and improves the extensibility of Conductor, we believe that this change should be made as part of a major version release. We will evaluate this and look into integrating this feature into the next major release (v3.0)

1reaction
Jiehongcommented, Aug 4, 2022

Version 3 happened, but it was not changed… (thanks github-bot I guess?)

@apanicker-nflx could you please re-open this?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Current Transformer (CT) Wire Extension
Since our standard CT wires are 22 to 18 AWG, we recommend extending the CT leads with the same or larger gauge wire....
Read more >
Conductor Documentation
Scalable Workflow Orchestration. Conductor is a platform created by Netflix to orchestrate workflows that span across microservices. Get Started.
Read more >
Flex® Conductor's Stand - Wenger Corporation
Versatile, adjustable conductor's stand with a modern design. Used alone or as part of the Flex® Conductor's System, the Flex® Conductor's Stand lets...
Read more >
US3717854A - Conductor grids for post and film memory systems ...
A conductor grid for a post and film memory system comprises first elongated, flat conductors having arms extending orthogonally to the length of...
Read more >
Extending the Life of Overhead Aging Assets with Focus on the ...
The focus of this paper is “Extending the Life of Overhead Aging Assets” of the ... This of course requires new conductor to...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found