urlparse can not parse s3 url correctly

After setting s3 bucket, an error occurs:

S3 datastore operation _put_s3_object failed (Parameter validation failed:
Invalid bucket name "": Bucket name must match the regex "^[a-zA-Z0-9.\-_]{1,255}$" or be an ARN matching the regex "^arn:(aws).*:s3:[a-z\-0-9]+:[0-9]{12}:accesspoint[/:][a-zA-Z0-9\-]{1,63}$"). Retrying 7 more times..

This is due to in metaflow/datastore/s3.py urlparse can not figure out schema and netloc correctly.

A simple workaround is replacing the following content

try:
    # python2
    from urlparse import urlparse
    import cStringIO
    BytesIO = cStringIO.StringIO
except:
    # python3
    from urllib.parse import urlparse as offcial_urlparse
    import io
    BytesIO = io.BytesIO

with

try:
    # python2
    from urlparse import urlparse as offcial_urlparse
    import cStringIO
    BytesIO = cStringIO.StringIO
except:
    # python3
    import io
    from urllib.parse import urlparse as offcial_urlparse
    BytesIO = io.BytesIO
# modified by Kevin
# 07/12/2019
def urlparse(path):
    return offcial_urlparse(path if path.startswith('s3:') else 's3://' + path)

There should be a more elegant way to fix the issue

[savingoyal]

It will work if you remove the s3:// prefix. We will make a small patch to handle this in the next release.

[xiaochuan-du]

It will work if you remove the s3:// prefix. We will make a small patch to handle this in the next release.

Thanks, mate. It helps