Turning on Polly makes puppeteer do hundreds of requests

I am using jest + puppeteer to run tests. I am trying to use polly to record and serve requests to our API when running integration tests.

What happens when i turn on Polly to record our requests is that it starts running the same request for hundreds of times.

The packages I am using: PuppeteerAdapter, FSPersister. When I turn off Polly the request completes successfully.

I recorded a video of the chromium’s console: https://gfycat.com/EssentialShadowyAnura

Here are the versions I am using:

    "@pollyjs/adapter-puppeteer": "^1.1.0",
    "@pollyjs/core": "^1.1.0",
    "@pollyjs/persister-fs": "^1.0.1",

and the configs:

Server

{
      recordingsDir: path.join(__dirname, 'recordings'),
      quiet: false,
      port: 3001,
      host: 'localhost'
}

Polly

{
      adapters: ['puppeteer'],
      adapterOptions: {
        puppeteer: { page }
      },
      persister: 'fs',
      persisterOptions: {
        host: 'http://localhost:3001'
      },
      logging: true
}

Is there something I am missing in the config? Or in general?

[offirgolan]

Fixed with @pollyjs/adapter-puppeteer@1.1.1. @meikoudras thanks again for the reproduction, it was super helpful!

[meikoudras]

Thank you for the quick fix!

I have updated the repo with another issue which seems to be related to CORS as well: https://github.com/meikoudras/jest-puppeteer-polly-test

The previous get request will work correctly but making a post request will again make the browser crash. I can make a separate issue for that as well, if that is required.

EDIT:

I think it is related to the handleRequest call here

When recording the initial response the preflight options request goes through here and makes puppeteer crash. When I fake a successful response to the options request everything works as expected.

So probably during a preflight request it should probably call:

request.continue();

And if the passthrough header is set it should fake the response.

Or is there a use case where a preflight requests response should be recorder in any way?