Overriding core plugin lifecycle methods

The core @netlify/functions plugin exposes a buildFunctions hook.

I had some logic included (before the refactor) that would allow for plugins to hook in and override the default functionality

This was the override plugin

function newFunctionsPlugin(conf) {
  return {
    '@netlify/functions:buildFunctions': () => {
      console.log('do my custom function thing')
    },
  }
}
module.exports = newFunctionsPlugin

@netlify/functions:buildFunctions was detected when constructing the build lifecycle and overrode the default function (located in @netlify/functions)

The old functionality was here: https://github.com/netlify/build/blob/401cca33085c844886e60177de4e1a4ef4917f38/packages/build-core/src/build.js#L414-L416

[DavidWells]

the override is using the plugin ID but I am realizing this does not make sense. We should use the package name. Is that correct?

Yeah I think it needs to be the package name because users can name the logicalId anything they want.

the overridden plugin must be defined before the plugin that overrides it. I think this was the original behavior but is this intended?

Yeah the order matters right now.

---

Sidenote: It’s also possible for users to override plugins like this:

const whateverPlugin = require('the-plugin')

module.exports = function myPluginWithOverride() {
  const originalPlugin = whateverPlugin({ foo: 'bar'})

  return Object.assign({}, originalPlugin, {
    postBuild: () => { /* change originalPlugin postBuild */}
  })
}

plugins:
   myPluginWithOverride:
      type: /plugins/myPluginWithOverride.js
      config: ...

This makes plugins very flexible for users to customize

[ehmicky]

Fixed by #204.