question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Feat: use react component for dialogs instead of window alerts

See original GitHub issue

Is your feature request related to a problem? Please describe. There are several places in the code that use window.confirm/alert for dialogs (one example is when uploading an existing media file).

I think we should should consider switching to a friendlier UI (maybe we can use the existing redux-notifications package we’re using for status messages).

Describe the solution you’d like Use a react component for dialogs instead of window dialogs.

Describe alternatives you’ve considered We can write our own modals but I’m guessing there should be a library for that.

Additional context Related to this https://github.com/netlify/netlify-cms/issues/2822

Issue Analytics

  • State:open
  • Created 4 years ago
  • Reactions:4
  • Comments:6 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
erezrokahcommented, Feb 7, 2022
1reaction
erezrokahcommented, Feb 7, 2022

I think we’ll be good with using an external package for this, as long as it’s not deprecated/archived and gets security updates

Read more comments on GitHub >

github_iconTop Results From Across the Web

The neatest way to handle alert dialogs in React
The neatest way to handle alert dialogs in React ; const isConfirmed = ; const YourAwesomeComponent = ; export const useConfirmationService ...
Read more >
Build Your Own Confirm Dialog & Notification Material UI
Build Confirm Dialog & Notification with React Material UI.In this react material UI tutorial, we discuss how to create custom confirm ...
Read more >
Alert: implementation · Issue #1026 · necolas/react-native-web
Providing no buttons argument manifests a basic alert. Providing buttons presents a dialogue. The fourth options argument is not implemented as ...
Read more >
How to Display Modal Dialog in React with react-modal
In this article, we will learn how to display a modal dialog in React applications using react-modal. We will see how to configure...
Read more >
React Dialog component - Material UI - MUI
Dialogs inform users about a task and can contain critical information, require decisions, or involve multiple tasks. A Dialog is a type of...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found