Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Improve error handling of invalid JSON in `audits`

See original GitHub issue

When the audits inputs contains invalid JSON, the error message is currently:

Unexpected token o in JSON at position 1 
    /opt/build/repo/node_modules/@netlify/plugin-lighthouse/src/config.js:46:19 getConfiguration
    /opt/build/repo/node_modules/@netlify/plugin-lighthouse/src/index.js:214:26 onPostBuild

Adding some try/catch/failBuild block around JSON.parse() could help build a more precise error message.

https://github.com/netlify-labs/netlify-plugin-lighthouse/blob/ca0f50b66ad1531f100cc78202798f46de319868/src/config.js#L46

Bugsnag error

Issue Analytics

State:
Created 3 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

ehmickycommented, Sep 10, 2020

For information, schema validations on inputs is being drafted at https://github.com/netlify/build/issues/1053, but we never got around to implementing it. I think most of the implementation time will actually be in building the UI for this.

0reactions

erezrokahcommented, Sep 10, 2020

🎉 This issue has been resolved in version 1.4.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀