Counterintuitive behavior of method io.netty.buffer.AbstractByteBuf#readBytes(int)

Expected behavior

The following code should print both true or both false:

public static void main(String[] args) {
        ByteBuf heapBuffer =  new PooledByteBufAllocator(false).heapBuffer(1, 1).writeByte(1);

        ByteBuf buffer_a = heapBuffer.readBytes(0);
        ByteBuf buffer_b = heapBuffer.readBytes(1);

        System.out.println(buffer_a.isDirect());
        System.out.println(buffer_b.isDirect());
    }

Actual behavior

buffer_a.isDirect() printed true , buffer_b.isDirect() printed false.

Steps to reproduce

See above

Minimal yet complete reproducer code (or URL to code)

See above

Netty version

4.1

JVM version (e.g. java -version)

1.8

OS version (e.g. uname -a)

MacOS

[laosijikaichele]

@trustin, Thanks a lot for the explanation, it really makes sense someway. Maybe I can add this explanation to the doc of method io.netty.buffer.EmptyByteBuf#isDirect, so that more people can better understand it.

[trustin]

Great. Looking forward to your pull request 🙇