question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

DriftNettyServerConfig with assumeClientsSupportOutOfOrderResponses=false is processing requests out of order

See original GitHub issue

Summary

When DriftNettyServerConfig is configured with ```assumeClientsSupportOutOfOrderResponses = false`` then writing 2 messages should cause polling for the 2nd message to return null instead of an object.

This is causing unit test failures in the Drift project of Presto, see https://github.com/prestodb/drift/issues/15, and happens after changing the Netty version to >= 4.1.38

See https://github.com/prestodb/drift/pull/22

Expected behavior

Netty server should only process the second message after we are done with the first request.

Actual behavior

Netty server starts processing the second message (its state is PENDING) even though the first request is not done.

Steps to reproduce

See PR https://github.com/prestodb/drift/pull/22 on repro-steps Install JDK 8 and mvn 3.5.0

git clone git@github.com:prestodb/drift.git
cd drift/drift-transport-netty
mvn clean test -Dtest=TestDriftNettyServerTransport

Minimal yet complete reproducer code (or URL to code)

Netty version

4.1.38.Final

JVM version (e.g. java -version)

1.8.0_261

OS version (e.g. uname -a)

Mac OS Catalina 10.15.5 - Darwin Kernel Version 19.5.0

Issue Analytics

  • State:open
  • Created 3 years ago
  • Comments:13 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
normanmaurercommented, Nov 12, 2021

Yes… I will have a look next week

0reactions
ajaygeorgecommented, Apr 15, 2022

@normanmaurer Wondering if you had a chance to look at this.

Read more comments on GitHub >

github_iconTop Results From Across the Web

No results found

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found