DriftNettyServerConfig with assumeClientsSupportOutOfOrderResponses=false is processing requests out of order
See original GitHub issueSummary
When DriftNettyServerConfig
is configured with ```assumeClientsSupportOutOfOrderResponses = false`` then writing 2 messages should cause polling for the 2nd message to return null instead of an object.
This is causing unit test failures in the Drift project of Presto, see https://github.com/prestodb/drift/issues/15, and happens after changing the Netty version to >= 4.1.38
See https://github.com/prestodb/drift/pull/22
Expected behavior
Netty server should only process the second message after we are done with the first request.
Actual behavior
Netty server starts processing the second message (its state is PENDING) even though the first request is not done.
Steps to reproduce
See PR https://github.com/prestodb/drift/pull/22 on repro-steps Install JDK 8 and mvn 3.5.0
git clone git@github.com:prestodb/drift.git
cd drift/drift-transport-netty
mvn clean test -Dtest=TestDriftNettyServerTransport
Minimal yet complete reproducer code (or URL to code)
Netty version
4.1.38.Final
JVM version (e.g. java -version
)
1.8.0_261
OS version (e.g. uname -a
)
Mac OS Catalina 10.15.5 - Darwin Kernel Version 19.5.0
Issue Analytics
- State:
- Created 3 years ago
- Comments:13 (8 by maintainers)
Top GitHub Comments
Yes… I will have a look next week
@normanmaurer Wondering if you had a chance to look at this.