Http2ConnectionHandler#goAway should not initiate channel graceful shutdown
See original GitHub issueIntroduced by #9094, in Http2ConnectionHanlder, when there is no active stream, doing GO_AWAY with error code NO_ERROR will immediately shut down the channel once the GO_AWAY frame is sent. This breaks higher layer implementation’s logic of graceful shutdown, such as in gRPC. Now that the GOAWAY(<max id>)
, PING
, PING(ACK)
, GOAWAY(<real id>)
approach is left for higher layer implementations, graceful shutdown should not be initiated in Http2ConnectionHandler#goAway(...)
.
Issue Analytics
- State:
- Created 4 years ago
- Comments:8 (7 by maintainers)
Top Results From Across the Web
Graceful shutdown · Issue #528 · http-rs/tide - GitHub
It's critical from a production standpoint that a load balancer or swarm manager can initiate a controlled or graceful shutdown. Any requests ...
Read more >Implementing Graceful Shutdown in Go | RudderStack Blog
This post details the implementation of graceful shutdown on Rudder ... Go channels do not work in a broadcast way, only one go...
Read more >Graceful shutdown in Go http server | by Sam Wang - Medium
The above code, 1st line in main creates a done channel and it can only accept os.Signal type with 1 capacity, then 2nd...
Read more >Channels and Graceful shutdown deadlock - Stack Overflow
dont for loop on a channel with a default case. Just read from it and let it ... Signaling should just do signaling,...
Read more >How to handle signals with Go to graceful shutdown HTTP ...
We can create signal channel using, and use it to notify on incoming ... This function should start protocol-specific graceful shutdown, ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@voidzcy thanks a lot for verify the fix 😃
@normanmaurer I just pulled
4.1.37.Final-SNAPSHOT/ Fri Jun 07 21:05:54 UTC 2019
to build gRPC and it succeeded.