[Netty 5] Remove ReplayingDecoder

I propose we remove ReplayingDecoder in Netty 5.

The code might look convenient, but it’s relying on simulating continuations with exceptions - a constant, but still. It also needs to modify how ByteBuf behaves, while in the new Buffer API we wish to have maximally consistent behaviours.

If we remove the ReplayingDecoder, then the following decoders will have to be rewritten in terms of the regular ByteToMessageDecoder:

Socks5InitialRequestDecoder
MqttDecoder
StompSubframeDecoder
SocksInitResponseDecoder
Socks5CommandResponseDecoder
Socks5PasswordAuthRequestDecoder
CompatibleMarshallingDecoder
SocksAuthResponseDecoder
Socks5PasswordAuthResponseDecoder
WebSocket00FrameDecoder
Socks5CommandRequestDecoder
Socks4ClientDecoder
SocksCmdRequestDecoder
SocksInitRequestDecoder
Socks5InitialResponseDecoder
SocksAuthRequestDecoder
Socks4ServerDecoder

Issue Analytics

State:
Created 2 years ago
Reactions:1
Comments:7 (7 by maintainers)

Top GitHub Comments

1reaction

amizurovcommented, Sep 8, 2021

+1 can help with STOMP

0reactions

normanmaurercommented, Sep 29, 2021

@amizurov nope… this will be “main” only. I have all done, just running the testsuite atm.

Top Results From Across the Web

ReplayingDecoder (The Netty Project API Reference (3.5.13 ...

A specialized variation of FrameDecoder which enables implementation of a non-blocking decoder in the blocking I/O paradigm. The biggest difference between ...

ReplayingDecoder receives large amount of bytes when only ...

Hey there, I use ReplayingDecoder from the official Netty tutorial, here is the code ... ChannelHandlerContext; import io.netty.handler.codec.

binary - Netty 5.0.0: bytes from incomplete frame are discarded

PS: I'm not keen on using the ReplayingDecoder or ByteToMessageDecoder classes as fitting my decoder library around them would be too intrusive ...

io.netty.handler.codec.ReplayingDecoder - 即时通讯网

ReplayingDecoder 源码的在线查看和学习,来自 Netty 4.0.56. ... 4 * The Netty Project licenses this file to you under the Apache License, 5 * version 2.0...

ReplayingDecoder xref - Red Hat on GitHub - JBoss.org

15 */ 16 package org.jboss.netty.handler.codec.replay; 17 18 import java.net. ... you will probably want to 242 * replace a {@link ReplayingDecoder} ...