Netty BOM inherit from parent and its own dependency management
See original GitHub issueA BOM was recently added in #5994 but is not valid.
A BOM should only expose dependency management for the artifacts that the project produces (so in this case, netty artifacts). It should not have an opinion about third party dependencies (otherwise including that BOM in a project potentially overrides decisions that were made about them).
One way to fix that would be to stop inheriting from netty-parent
. Also, I’d set the version of each dependency in the bom rather than using ${project.version}
. If you’re including the bom for netty X.Y.Z, it should be X.Y.Z. and nothing else (Maven does not allow to override that property, which is good so it’s not strictly necessary but the intent is more clear if you hardcode the current version).
Here is an example of BOM for reference: http://repo.spring.io/release/org/springframework/spring-framework-bom/4.3.8.RELEASE/spring-framework-bom-4.3.8.RELEASE.pom
We’d like to use this bom in Spring Boot but we can’t for that reason.
Issue Analytics
- State:
- Created 6 years ago
- Reactions:1
- Comments:7 (7 by maintainers)
Yes, you got it.
to answer myself I believe the answer is yes, just tested with the following… mvn --batch-mode release:update-versions -DdevelopmentVersion=4.1.11.Final-SNAPSHOT