question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Netty BOM inherit from parent and its own dependency management

See original GitHub issue

A BOM was recently added in #5994 but is not valid.

A BOM should only expose dependency management for the artifacts that the project produces (so in this case, netty artifacts). It should not have an opinion about third party dependencies (otherwise including that BOM in a project potentially overrides decisions that were made about them).

One way to fix that would be to stop inheriting from netty-parent. Also, I’d set the version of each dependency in the bom rather than using ${project.version}. If you’re including the bom for netty X.Y.Z, it should be X.Y.Z. and nothing else (Maven does not allow to override that property, which is good so it’s not strictly necessary but the intent is more clear if you hardcode the current version).

Here is an example of BOM for reference: http://repo.spring.io/release/org/springframework/spring-framework-bom/4.3.8.RELEASE/spring-framework-bom-4.3.8.RELEASE.pom

We’d like to use this bom in Spring Boot but we can’t for that reason.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Reactions:1
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
jasontedorcommented, Apr 27, 2017

Yes, you got it.

1reaction
johnoucommented, Apr 27, 2017

to answer myself I believe the answer is yes, just tested with the following… mvn --batch-mode release:update-versions -DdevelopmentVersion=4.1.11.Final-SNAPSHOT

Read more comments on GitHub >

github_iconTop Results From Across the Web

Spring boot starter dependency overwrites netty version of the ...
Your pom will be inheriting a dependencyManagement section from the spring poms you have used in its parent hierarchy.
Read more >
Using Maven's Bill of Materials (BOM) - Reflectoring
This newly created project will inherit the dependencyManagement section and Maven will use it to resolve the dependencies required for it.
Read more >
netty-parent : 4.1.58.Final - Maven Central Repository Search
Netty is an asynchronous event-driven network application framework for rapid development of maintainable high performance protocol servers and clients.
Read more >
Overriding Spring Boot Managed Dependency Versions
Most Spring Boot projects inherit from the spring-boot-starter-parent artifact, which itself inherits from the spring-boot-dependencies ...
Read more >
Developing with Spring Boot
Dependency Management. Each release of Spring Boot provides a curated list of dependencies that it supports. In practice, you do not need to ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found