Query parameter name is encoded while it shouldn't be

Expected behavior

Query parameter name shouldn’t be encoded.

Actual behavior

Query parameter name is encoded.

Steps to reproduce

If we go to following code, you will notice that we are encoding the query parameter name as well. I am wondering why would query parameter name needed to be encoded.

QueryStringEncoder.java

Also, if you look at unit test, it also don’t test any specific use-case for parameter name to be encoded, although there are unit tests around parameter value to be encoded.

QueryStringEncoderTest.java

We works as a proxy app, and using Vertx, which in-turn uses Netty, and when we proxy following request, it causing the query parameter name being encoded while (probably) it shouldn’t.

Input /server/path?jREJBBB5x2AaiSSDO0/OskoCztDZBAAAAAADV1A4

Output /server/path?jREJBBB5x2AaiSSDO0%2FOskoCztDZBAAAAAADV1A4

Please note that in sample above there is no value defined for the parameter. This is how we receive from a Windows device, so we are suppose to proxy it as-is.

Please See Vertx issue for reference - https://github.com/eclipse/vert.x/issues/2544

Netty version

4.1.x

JVM version (e.g. java -version)

1.8_181

[manish-panwar]

@arushi315 - Can you please look into Java 11?

[normanmaurer]

Closing as it seems like this is not a bug