question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add public config for Span reservoir size and ensure that correct value is being applied

See original GitHub issue

Agents should implement a new public config that allows customers to change the Span reservoir size used for DT. The config should work with yaml, system property, and environment variables of the following forms:

Yaml

  span_events:
    max_samples_stored: 1000

System property

-Dnewrelic.config.span_events.max_samples_stored=1000

Environment variable

NEW_RELIC_SPAN_EVENTS_MAX_SAMPLES_STORED=1000

The default reservoir size will remain 1000. Agents need to report the locally set reservoir size to the Connect Service which will send back the final limit to be applied by the agent. This is so that the Connect Service can impose an acceptable limit in cases where an extremely high limit was configured locally. Currently, the Connect Service will impose a max limit of 10,000. See Connect spec for full details.

The collector changes to support this behavior are live in staging. You can add your own staging account to this feature flag or simply use the Java Agent Testing staging account that is already added.

When the agent receives the final limit from the Connect Service and applies it, a Supportability/SpanEvent/Limit supportability metric must be reported with the value of the final decided upon Span reservoir size. See Span-Events spec for full details.


Add tests for the new config and supportability metric. Ensure that all test suites (unit, functional, instrumentation, and AITs) pass.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
XiXiaPdxcommented, Sep 13, 2021

The collector changes that support this behavior are now live in staging and production for all accounts. https://newrelic.slack.com/archives/C0290QGR02V/p1631555632078400

Read more comments on GitHub >

github_iconTop Results From Across the Web

Design Zone for Branch/WAN - Cisco SD-WAN Design Guide
This design guide provides an overview of the Cisco SD-WAN solution. It discusses the architecture and components of the solution, including control plane, ......
Read more >
Water supply and drainage in buildings - GovInfo
In the United States, the process by which plumbing systems are planned, designed, constructed, and operated is highly regulated by.
Read more >
Chapter 9: Plumbing | Healthy Housing Reference Manual
The size of the drain is based on the fixture units flowing into the pipe and the slope of the drain. Table 9.2...
Read more >
Hoisting & Rigging Fundamentals
Explain the proper use and limitations of the various rigging equipment and hardware (wire rope, synthetic web slings, shackles, eyebolts, hooks, etc.).
Read more >
Software Tutorial - Beckman Coulter
IMPORTANT IMPORTANT is used for comments that add value to the step or procedure being performed. ... Ensuring the Deck in Biomek Software...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found