Request: --ico should not really require a rebuild

Currently it’s quite inconvenient and confusing (not clear) that --ico option requires --build. It is possible (and easy enough) to change the icon and other resources of an executable, for example by using https://github.com/electron/rcedit

However, applying this tool on the final nexe app (after the script is embedded) will break the executable:

I assume it can be safely applied to a pre-built executable

[calebboyd]

@simonbuchan de42dd94adf9b1fe6bdf438359965a532540a5f8 re-orders the download step and its now performed before the plugins/patches run. So patches can operate on the file.

[simonbuchan]

With further testing, the above doesn’t quite work for this in general: the problem is that patches and plugins are the last arguments to compose in nexe.ts, which means they can’t run any code after the cli step pulls down the binary.

Probably the simplest workaround is to just use the plugin to grab the output path, then run outside the compile call:

let location;
await compile({
  ...
  plugins: [
    (compiler, next) => {
      location = compiler.getNodeExecutableLocation(compiler.target);
      return next();
    }
  ]
})

await promisify(rcedit)(location, { icon: ico, "version-string": rc });