AdvertisingPacketUtil:getAdvertisingPacketsBetween() Skip one advertising packet

Hello,

According to the description, the method below “Returns an ArrayList of AdvertisingPackets that have been received in the specified time range.”

public static <P extends AdvertisingPacket> ArrayList<P> getAdvertisingPacketsBetween(final ArrayList<P> advertisingPackets, long startTimestamp, long endTimestamp) {
          ...
    }

I am testing this method right now, Here is my input data :

long startTimestamp = 1533538629;
long endTimestamp = 1533538899;
         
ArrayList<AdvertisingPacket> advertisingPackets = new ArrayList<AdvertisingPacket>();
advertisingPackets.add(new AdvertisingPacket(1, 1533538511));
advertisingPackets.add(new AdvertisingPacket(2, 1533538629));
advertisingPackets.add(new AdvertisingPacket(3, 1533538686));
advertisingPackets.add(new AdvertisingPacket(4, 1533538737));
advertisingPackets.add(new AdvertisingPacket(5, 1533538772));
advertisingPackets.add(new AdvertisingPacket(6, 1533538805));
advertisingPackets.add(new AdvertisingPacket(7, 1533538849));
advertisingPackets.add(new AdvertisingPacket(8, 1533538865));
advertisingPackets.add(new AdvertisingPacket(9, 1533538884));
advertisingPackets.add(new AdvertisingPacket(10, 1533538899));
advertisingPackets.add(new AdvertisingPacket(11, 1533538912));
advertisingPackets.add(new AdvertisingPacket(12, 1533539012));

After calling getAdvertisingPacketsBetween method with the input above the result returned is [ 2, 3, 4, 5, 6, 7, 8, 9], Why we aren’t taking the index number 10 with the array ? I think it’s a bug, Every endTimestamp chosen > 6 ( which it’s the middle of the list), the last index is skipped.

To Solve the issue above, we should add 1 to the endIndex calculated when endTimestamp >= midstAdvertisingPacket.getTimestamp()

    // find the index of the last advertising packet with a timestamp
        // smaller than the specified endTimestamp
        int endIndex = advertisingPackets.size() - 1;
        if (endTimestamp < latestAdvertisingPacket.getTimestamp()) {
            // figure out if the end timestamp is before or after the midst advertising packet
            ListIterator<P> listIterator;
            if (endTimestamp < midstAdvertisingPacket.getTimestamp()) {
                // end timestamp is in the first half of advertising packets
                // start iterating from the beginning
                listIterator = advertisingPackets.listIterator(startIndex);
                while (listIterator.hasNext()) {
                    if (listIterator.next().getTimestamp() >= endTimestamp) {
                        endIndex = listIterator.previousIndex();
                        break;
                    }
                }
            } else {
                // end timestamp is in the second half of advertising packets
                // start iterating from the end
                listIterator = advertisingPackets.listIterator(advertisingPackets.size());
                while (listIterator.hasPrevious()) {
                    if (listIterator.previous().getTimestamp() < endTimestamp) {
                        endIndex = listIterator.nextIndex() + 1;  <------ HERE
                        break;
                    }
                }
            }
        }

[hadiidbouk]

Where is the line c) ? Also can you please add “java” after the code block, it’s more clear to read the code. Like so

``java <-- three ` not two

``

[marvinmirtschin]

Fixed in #122