question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Accordion: decide what to do with panels

See original GitHub issue

Current accordion implementation is based on .panel-... css classes, that are already removed from the BS4.

Current markup:

<div class="panel panel-default">
  <div class="panel-heading">
    <h4 class="panel-title">
      ...
    </h4>
  </div>
  <div class="panel-collapse">
    <div class="panel-body">
      ...
    </div>
  </div>
</div>

So there might be several solutions for the accordion:

  • There are card- classes as alternatives, (but I don’t see any benefit in creating a standalone NgbCard component from it)
  • We might generate an empty markup and just stack user provided title and content templates
  • Get rid of the accordion 😃
  • Something else ?

Will add a plunker link soon with examples

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
maxokorokovcommented, Jul 8, 2016
0reactions
sendilkumarncommented, Jul 8, 2016

this layout is really good than existing.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Accordion Design: UI Best Practices & Examples - HubSpot Blog
Panels can be composed of bullet points or multiple paragraphs, but they should be brief and descriptive like accordion headers.
Read more >
Accordion – Carbon Design System
Accordions can be placed with main page content or placed inside of a container such as a side panel or tile. accordion placement....
Read more >
Accessible Accordion - examples and best practices - Aditus
Assign unique id's. To make the accordion header and panel "identifiable" when assigning the relationships between them, we first need to assign unique...
Read more >
Panels Accordion | Drupal.org
Panels Accordion provides an accordion display within Panels. By using accordions you can fit more content into smaller areas and allow your ...
Read more >
Accordion - Reach UI
If you want to control the accordion's open panels, you can do so by passing index and onChange props. The index corresponds with...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found