Alternative Date adapters

Now that we have an NgbDateAdapter, it might be nice to bundle a couple of default ones with the library:

• NgbDateNativeAdapter - as seen in the datepicker adapter demo to use with native JS date
• NgbDateISOAdapter - to conform with ISO 8601 Dates
• NgbDateMomentAdapter - for use with moment js

[tech-no-logical]

my super simple ISO implementation, fwiw :

function padNumber(value: number) {
  if (isNumber(value)) {
    return `0${value}`.slice(-2);
  } else {
    return '';
  }
}

@Injectable()
export class NgbIsoDateAdapter extends NgbDateAdapter<string> {
  fromModel(date: string): NgbDateStruct {

    const parsedDate = /(\d\d\d\d)-(\d\d)-(\d\d)/.exec(date);
    if (parsedDate) {
      return <NgbDateStruct>{ year: Number(parsedDate[1]), month: Number(parsedDate[2]), day: Number(parsedDate[3]) };
    } else {
      return null;
    }
  }
  toModel(date: NgbDateStruct): string {
    if (date) {
      return date.year + '-' + padNumber(date.month) + '-' + padNumber(date.day);
    } else {
      return null;
    }
  }
}

[jeroenheijmans]

For what it’s worth, I’ve just crafted a Moment.js adapter with a few basic smoke tests. The full deal is in a public gist, here’s the adapter bits:

// Might need to polyfill depending on needed browser support...
const isInt = Number.isInteger;

@Injectable()
export class NgbMomentjsAdapter extends NgbDateAdapter<moment.Moment> {

  fromModel(date: moment.Moment): NgbDateStruct {
    if (!date || !moment.isMoment(date)) {
      return null;
    }

    return {
      year: date.year(),
      month: date.month() + 1,
      day: date.date(),
    };
  }

  toModel(date: NgbDateStruct): moment.Moment {
    if (!date || !isInt(date.day) || !isInt(date.day) || !isInt(date.day)) {
      return null;
    }

    return moment(`${date.year}-${date.month}-${date.day}`, 'YYYY-MM-DD');
  }
}

I think there’s a util based version of isInt in the library itself that might be useful instead of Number.isInteger.

But, at the bottom line, I guess @maxokorokov has a point that it’s not so nice to pull in Moment.js as a dependency just to demonstrate something. Not sure what the solution would be for that (if any).