Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Rating: decide on how to display stars

See original GitHub issue

As of today we are adding and CSS classes but those classes are not part of Bootstrap’s CSS. We need to either:

add dependency on an external lib / font
include required classes as part of the wdiget
use UTF character
figure out sth else 😃

Issue Analytics

State:
Created 7 years ago
Comments:8 (7 by maintainers)

Top GitHub Comments

2reactions

Foxandxsscommented, Jul 5, 2016

Let’s use UTF characters today. Swap it if needed to something else.

UTF characters have no dependencies and works fine. Better than adding one of those fonts and then realize we don’t want it.

1reaction

maxokorokovcommented, Jul 4, 2016

I did a bit of research and as fast/ugly solution there are two entities ★ (&#9733😉 and ☆ (&#9734😉 that seem to render for me in the IE9, IE11, Safari, Firefox. They look quite ugly in IE because of antialiasing though, but so do all other symbols.

Secondly, all the major icon providers render in the same way (from here):

Font Awesome 
Glyphicons 
Material Design 
Ionicons 
Foundation Icon Fonts 
Elusive Icons

So looks like giving the ability to simply specify ‘on’ and ‘off’ classes in the rating component would cover these use cases. And fallback to the mentioned characters if nothing specified. Plus there might be a global component configuration to avoid setting this on a per-instance basis

Another option would be to allow user to provide a template element, but this is an overkill I think.