Tabset (change) event gets fired in non-related situations.

Bug description:

Basically what happens is that if an is inside a tab, any method associated with the tabset’s (change) event will get fired if the input’s value changes (and the input loses focus).

So the event gets triggered if either a selected tab changes or if an input field’s value changes inside the tab changes.

My personal case is the following. On a (change) event I run code that changes the route to include the open tab in the parameters. One of the tabs has a form. By changing a form input value in that form, the route change function runs and another tab opens.

To make it work I’m using this hack:

onTabSelect(data: NgbTabChangeEvent) {
if (data.hasOwnProperty('nextId')) { 
            this._router.navigate(...);
        }   
}

Angular: 2.0.0

ng-bootstrap: 1.0.0.alpha-4

Bootstrap: 4.0.0.alpha-4

EDIT: I now realize I probably should have replied here instead: #594

[pkozlowski-opensource]

@jnizet ref: https://github.com/angular/angular/issues/11666

[pkozlowski-opensource]

is your change a workaround for an angular issue, or is it expected behavior?

I expect it to be debated 😃 And I think that it actually makes sense to have a specific event name so it stands out in a template, hence the PR.

we should be very careful never to name an output as a standard dom event for directives that wrap content.

At least for events that bubble, yes.

BTW, the same bug probably also exists in accordion, which also has a change output.

Yes. I was just waiting for the reaction to my 1st PR 😃