Translation support

We need to make sure that people can translate strings in ng-bootstrap widget templates. Things to do:

• list widgets and their parts which might require tranlations
• select a set of supported translation solutions
• make the necessary changes to the existing templates and code

The current thinking is that we will support Angular translations so the majority of the process should boil down to adding i18n attributes in the templates of widgets needing translations

[jnizet]

Here’s a list of labels to mark for i18n:

• alert.ts: Close
• carousel.ts: Previous, Next
• datepicker-navigation.ts: {{ i18n.getMonthFullName(month.number) }} {{ month.year }} (not sure about this, but the order of these two elements could change depending on the locale)
• pagination.ts: ««, «, (current), », »», First, Previous, Next, Last
• progressbar.ts: {{getPercentValue()}}% (because some locales might want those in a different order, or with a space between the value and the percent symbol)
• rating.ts: ★, ☆ (not sure here, but it could be useful to use other symbols by default, without having to provide a specific star template)
• timepicker.ts: Increment hours, HH, Hours, Decrement hours, Increment minutes, MM, Minutes, Decrement minutes, Increment seconds, SS, Seconds, Decrement seconds, PM, AM

I would also add the following to the things to do:

• decide about a naming convention for i18n IDs, and apply this convention for each i18n.

My proposal would be to use ngb.<widget-name>.label-in-dash-case. For example, the label “Decrement hours” would be marked using

<span class="sr-only" i18n="@@ngb.timepicker.decrement-hours">Decrement hours</span>

[maxokorokov]

@pkozlowski-opensource @jnizet, oh I have nothing against the PR, on the contrary actually! Was just trying to think of use cases that default solution doesn’t cover and see the impact.

For instance, for angular/material they’ve decided to have a translation service, ex: https://material.angular.io/components/datepicker/api#MatDatepickerIntl And with the changes: Subject<void> to refresh… Haven’t researched why, but most likely real life use cases?

Anyway we shouldn’t invent our own translation system right now. And services like in the link above could be added on top / in parallel later if necessary.

@jnizet

I haven’t found such a text in the rating’s template

Yep, because it’s actually in one of methods; But I like your idea as a workaround, I think it should work.