typeahead: constant dropdown items re-rendering

On the demo site the whole suggestion list for typeahead gets re-rendered on any event. For example on arrow up, arrow down, hovering mouse over items, etc.

I would expect only the active css class to change

[maxokorokov]

@Basewq I just tested it and this removes both excessive rendering and (click) issues inside the template. Indeed, looks like the issue was doing new ResultTplCtx() each time. Simple enough fix for me, thanks! Opened a pull request.

[Basewq]

I think the issue can be solved by inlining the ngOutletContext object in typeahead-window, ie. <template [ngTemplateOutlet]="resultTemplate || rt" [ngOutletContext]="_prepareTplCtx(result)"></template> to <template [ngTemplateOutlet]="resultTemplate || rt" [ngOutletContext]="{result:result, term: term, formatter: formatter}"></template>

Excuse the messy plunker: https://plnkr.co/edit/yHFIDu7xKhISlGzoDY39?p=preview I tested changing the line in file src/typeaheadwin.ts and it seems to stop the rerendering on mouse events.

Can someone test this is the case?

If this is indeed the fix, can we try reverting back the mousedown event to click (#527), as most people expect the selection to occur on mouse up, as I think the mouse event issue was caused by some sort of race condition with the re-rendered template.