built dist folder contains a ton of node_modules folders full of README.md files

Type of Issue

[x] Bug Report
[ ] Feature Request

Description

I seem to have the same problem as described in issue #2418, so the fix doesn’t seem to work on my side. However in my case, I have 2x node_modules in my project because I separated Cypress into its own folder with its own node_modules. I did not have that problem in previous version 13.x of ng-packagr, so that seems like a regression

root
 node_modules
 src
 test
   cypress
     node_modules

How To Reproduce

my project is open sourced and can be clone from here https://github.com/ghiscoding/Angular-Slickgrid

running npm run packagr should reproduce the issue

Expected Behaviour

in my case the test/ folder should not be included, I also thought that my .npmignore would be excluding that folder when publishing but it turns out that since it’s not part of the dist/ folder, then it will completely skip the .npmignore (as explained in this SO) and so my unwanted test/ folder is being publishing as can be seen in this unpkg link: https://unpkg.com/browse/angular-slickgrid@5.0.0/

What I could do in the meantime is to copy my root .npmignore inside the dist/ folder after it’s packaged, but it’s quite inconvenient but still is the only temporary solution that works and I’ll go with that for now until the issue is fixed (hopefully)

Version Information

$ node_modules/.bin/ng-packagr --version
ng-packagr: ^14.2.1
@angular/*: ^14.1.2
typescript: ~4.7.4
rxjs: ^7.5.6
node: 16.18.0
npm/yarn: 8.10.0

Please include all version numbers that might be relevant, e.g. third-party libraries

[alan-agius4]

Note there might be one think I forgot to mention, I have 2 folders with node_modules, I moved Cypress E2E install into it’s own folder and you probably did not installed it when you first tried to replicate and it might be the reason you don’t see it on your side, so there’s 2 installs to run

Indeed that causes the problem.

[github-actions[bot]]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

_{This action has been performed automatically by a bot.}