Error during template compile, function calls are not supported in decorators.

Type of Issue

[X] Bug Report
[ ] Feature Request

Description

One of my libraries dependencies requires a .forRoot() call to declare the module with providers.

I am including this Module.forRoot() in my module and it works fine, however running packagr for the project fails on compilation.

How To Reproduce

import { DeviceDetectorModule } from 'ngx-device-detector';

@NgModule({
    imports: [
        DeviceDetectorModule.forRoot(),
    ],
   ...
}

BUILD ERROR
Error during template compile of 'EasyGridModule'
  Function calls are not supported in decorators but 'DeviceDetectorModule' was called.

Error: Error during template compile of 'EasyGridModule'
  Function calls are not supported in decorators but 'DeviceDetectorModule' was called.

    at Object.<anonymous> (C:\Users\Tyler\Documents\GitHub\@ngx-easy\node_modules\ng-packagr\lib\ngc\compile-source-files.js:69:35)
    at Generator.next (<anonymous>)
    at C:\Users\Tyler\Documents\GitHub\@ngx-easy\node_modules\ng-packagr\lib\ngc\compile-source-files.js:7:71
    at new Promise (<anonymous>)
    at __awaiter (C:\Users\Tyler\Documents\GitHub\@ngx-easy\node_modules\ng-packagr\lib\ngc\compile-source-files.js:3:12)
    at Object.compileSourceFiles (C:\Users\Tyler\Documents\GitHub\@ngx-easy\node_modules\ng-packagr\lib\ngc\compile-source-files.js:19:12)
    at Object.<anonymous> (C:\Users\Tyler\Documents\GitHub\@ngx-easy\node_modules\ng-packagr\lib\ng-v5\entry-point\ts\compile-ngc.transform.js:37:60)
    at Generator.next (<anonymous>)
    at C:\Users\Tyler\Documents\GitHub\@ngx-easy\node_modules\ng-packagr\lib\ng-v5\entry-point\ts\compile-ngc.transform.js:7:71
    at new Promise (<anonymous>)

Expected Behaviour

Successful compilation for publishing.

Version Information

    "@angular/compiler-cli": "^6.0.0-rc.1",
    "@angular-devkit/build-ng-packagr": "~0.5.10",
    "@angular-devkit/build-angular": "~0.5.10",
    "ng-packagr": "^2.4.2",
    "tsickle": ">=0.27.5",
    "tslib": "^1.9.0",
    "typescript": "2.7.2",
    "@angular/cli": "~6.0.0-rc.6",

[dherges]

preface: I hate tsconfig.

@wardbell ng-packagr auto-generates a tsconfig for build. TL;DR it’s just releasing 3.0.0-rc.3 that enables fullTemplateTypeCheck and should solve your specific build issue

Long story:

$ git clone https://github.com/johnpapa/angular-ngrx-data.git ngrx-data-FAIL
$ cd ngrx-data-FAIL
$ git checkout ng-v6-FAIL
$ npm install
/* edit node_modules/ng-packagr/lib/ts/conf/tsconfig.ngc.json */
$ cat node_modules/ng-packagr/lib/ts/conf/tsconfig.ngc.json 
{
  "angularCompilerOptions": {
    "annotateForClosureCompiler": true,
    "flatModuleId": "AUTOGENERATED",
    "flatModuleOutFile": "AUTOGENERATED",
    "skipTemplateCodegen": false,
    "strictMetadataEmit": false,
...
$ npm run build-lib 
...
Build success

The combinations I tried were:

Build success

    "skipTemplateCodegen": true,
    "strictMetadataEmit": true,
    "fullTemplateTypeCheck": true

    "skipTemplateCodegen": false,
    "strictMetadataEmit": false

Build failures

    "skipTemplateCodegen": false,
    "strictMetadataEmit": true
    // fullTemplateTypeCheck omitted (= default value)

    "skipTemplateCodegen": true,
    "strictMetadataEmit": true,
    // fullTemplateTypeCheck omitted (= default value)

    "skipTemplateCodegen": true,
    "strictMetadataEmit": false,
    // fullTemplateTypeCheck omitted (= default value)

[alan-agius4]

Looks like the @dynamic has no effect in this case. Though what I noticed was that setting fullTemplateTypeCheck does stop the error. I’ll log an error with Angular.