Looking for secondary entry points is VERY slow

Type of Issue

[x] Bug Report
[ ] Feature Request

Description

On Windows, the call “const findSecondaryPackagesPaths = (directoryPath, excludeFolder) =>” takes a very long time (about 1 minute). This slows down the build process tremendously.

I assume that this is because the file search does not exclude node_modules as a whole but only the package.json files inside the folder. This causes the scan to iterate over the complete directory, which is very slow.

How To Reproduce

Use ng-packager on Windows with a project that has a relatively large dependency tree.

Expected Behaviour

I would expect the scan for the secondary entry point to be either faster or see a way to disable it.

Version Information

ng-packagr:            3.0.2
@angular/compiler:     6.0.1
rollup:                0.59.4
tsickle:               0.27.5
typescript:            2.7.2

Please include all version numbers that might be relevant, e.g. third-party libraries

[CarstenLeue]

This pattern works for me:

'**/node_modules/**'

I have actually done a simple testcase to validate what files glob iterates over:

const Promise = require('bluebird');
const globFiles = Promise.promisify(require('glob'));

const directoryPath = __dirname;

const ignore = ['**/node_modules/**'];

const cache = {};

const res = globFiles(`${directoryPath}/**/package.json`, {
  ignore,
  cwd: directoryPath,
  cache
});

res.then(console.log).then(() => console.log('cache', cache));

The content of “cache” shows the touched files.

With the original pattern, the cache is filled with all files in node_modules. With the updated pattern this is not the case.

[github-actions[bot]]

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem. _{This action has been performed automatically by a bot.}