New TSConfig Management

Type of Issue

[ ] Bug Report
[ ] Feature Request
[x] discussion

Description

This discussion is created in order to permit a more global discussion about TSConfig management, customisation and refactoring, directly following https://github.com/dherges/ng-packagr/pull/790#discussion_r183844424.

[alan-agius4]

If you take into consideration a mono repo for example, that you mentioned. It is vital that the tsconfig is not part of static options. And you have a tsconfig with a custom baseUrl and paths to work. In fact I do have a starter kit for this which you can see here.

https://github.com/alan-agius4/ng-mono-repo-starter/blob/master/tsconfig.json https://github.com/alan-agius4/ng-mono-repo-starter/blob/master/tsconfig.build.json

Having full control of a tsconfig, Outside of ng-packagr is essential for this, As i rely on the ngc to properly parse the paths etc and not ng-packagr. As I said early, you cannot simply get some options and merge them with tsconfig, as this simple won’t work because when a tsconfig is parsed, it does much more than merging an object.

My point is, we should allow a full custom tsconfig, this is something quite important in my use cases. In case the user provides invalid configuration than we should warn them. By removing the functionality would have a huge impact.

Note on point 1 If the tools provide adequate error message why people are finding it hard to set up a valid tsconfig? In reality there are only 2-3 properties required. Tbh, its the same for ng cli if you create an invalid tsconfig it wont work. So, I think the best approach rather than merging etc, we should use a schematic and than just modify the values that need to be modified during build such as the output and declarationDir, baseUrl. etc. (Which are currently doing)

Note on point 3 You mentioned this requires refactoring, but in reality it doesn’t it just needs to revert this https://github.com/dherges/ng-packagr/pull/786/files, and it will just work out of the box, because tsconfig paths gets parsed by tsc/ngc

[github-actions[bot]]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

_{This action has been performed automatically by a bot.}